Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable_type_declaration to the @Symfony set #7821

Closed

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Feb 6, 2024

@lyrixx lyrixx force-pushed the use_nullable_type_declaration branch from d4ef518 to f26e323 Compare February 6, 2024 14:42
@lyrixx lyrixx changed the title Add use_nullable_type_declaration to the @Symfony set Add nullable_type_declaration to the @Symfony set Feb 6, 2024
@lyrixx lyrixx closed this Feb 6, 2024
@lyrixx lyrixx deleted the use_nullable_type_declaration branch February 6, 2024 14:42
@Wirone
Copy link
Member

Wirone commented Feb 6, 2024

Well, that was quick 😆.

@lyrixx
Copy link
Contributor Author

lyrixx commented Feb 6, 2024

Sorry, I made a mistake. There is something I don't understand actually.

In my config, I had to add this:

'nullable_type_declaration' => true,

like in Symfony

But on https://cs.symfony.com/doc/rules/function_notation/nullable_type_declaration_for_default_null_value.html, I see

@Symfony with config:

['use_nullable_type_declaration' => false]


I'm lost 😅

@kubawerlos
Copy link
Contributor

CONTRIBUTING.md exists for people that are lost, like yourself 😉

Also, https://cs.symfony.com/doc/rules/function_notation/nullable_type_declaration_for_default_null_value.html is out of date, this was already done, and is visible in the latest docs.

@Wirone
Copy link
Member

Wirone commented Feb 6, 2024

@lyrixx we have some problem with site deployment (#7790) so as @kubawerlos currently it's better to look at docs on Github.

@keradus can you fix it somehow?

@Wirone
Copy link
Member

Wirone commented Feb 6, 2024

@lyrixx docs are now fixed (I hope I did not caused any other problems, but at least proper version is deployed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants