feat: Support for multi-use statements in NamespaceUsesAnalyzer
#7814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `isInMulti` flag - move import type to the beginning of signature (I believe this is important information and should be clearly visible)
- Remove superfluous argument in test cases (test expects only 2 arguments from provider) - Add array shape for data providers
Wirone
added
kind/enhancement
kind/refactoring
topic/core
julienfalque
reviewed
Feb 4, 2024
…out when opt-in flag is not set
Co-authored-by: Julien Falque <julien.falque@gmail.com>
julienfalque
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this refactor/enhancement is being able to collect imports also from comma-separated and
{}-grouped multi-use statements. I decided to add explicitisInMultiflag, even though "multi" flag could be inferred from start-end chunk indices - I thought it's better, because maybe we can pass these chunk indices even for single symbols in the future.Change is backward compatible because class is marked as internal, and entry-point for collecting imports has opt-in flag, so all the fixers work exactly the same at this point. I'll create separate PRs that will show how this feature is used in practice.