Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Exclude topic/core issues/PRs from Stale Bot #7788

Merged

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Jan 30, 2024

Issues/PRs related to core features should be excluded from Stale Bot as these are part of internal vision for project development. We should apply topic/core label when we agree that something must be done in the Fixer's engine/architecture/design and keep it open (of course reviewing these issues from time to time is highly recommended).

@Wirone Wirone requested a review from keradus January 30, 2024 12:20
@Wirone Wirone self-assigned this Jan 30, 2024
@coveralls
Copy link

coveralls commented Jan 30, 2024

Coverage Status

coverage: 94.749%. remained the same
when pulling fbe81b7 on Wirone:codito/stale-bot-ignore-core-issues
into 8056c29 on PHP-CS-Fixer:master.

@Wirone Wirone enabled auto-merge (squash) January 30, 2024 12:27
@@ -52,6 +52,8 @@ jobs:
days-before-pr-close: "${{ env.DAYS_BEFORE_PR_CLOSE }}"
days-before-pr-stale: "${{ env.DAYS_BEFORE_PR_STALE }}"
exempt-all-milestones: true
exempt-issue-labels: "topic/core"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe even some label like "prevent-stale" to prevent stable bot on non-core topics

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I want meaningful labels that serve real purpose of cataloguing stuff, so I prefer not to add label just for ignoring - it's better to use multiple explicit labels for each Stale Bot's option if needed.

@keradus keradus disabled auto-merge January 30, 2024 21:55
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved and disabled auto-merge. check my comment and decide which way to go. both are OK for me.

@Wirone Wirone force-pushed the codito/stale-bot-ignore-core-issues branch from 5bbaa53 to fbe81b7 Compare January 31, 2024 07:00
@Wirone Wirone enabled auto-merge (squash) January 31, 2024 07:00
@Wirone Wirone merged commit 21f5b42 into PHP-CS-Fixer:master Jan 31, 2024
26 checks passed
@Wirone Wirone deleted the codito/stale-bot-ignore-core-issues branch January 31, 2024 07:07
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants