Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LowercaseStaticReferenceFixer - do not change typed constants #7775

Merged
merged 2 commits into from Jan 24, 2024
Merged

fix: LowercaseStaticReferenceFixer - do not change typed constants #7775

merged 2 commits into from Jan 24, 2024

Conversation

kubawerlos
Copy link
Contributor

Fixes #7771

@coveralls
Copy link

Coverage Status

coverage: 94.755%. remained the same
when pulling 622bd3e on 6b7562617765726c6f73:fix_LowercaseStaticReferenceFixer
into 49fc633 on PHP-CS-Fixer:master.

Wirone
Wirone approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pity that yields are without keys, but since other providers in this test class also lack them, then acceptable 😉.

@Wirone Wirone merged commit 0e5b5dc into PHP-CS-Fixer:master Jan 24, 2024
25 checks passed
@Wirone
Copy link
Member

Wirone commented Jan 24, 2024

Thanks @kubawerlos 🍻!

@kubawerlos kubawerlos deleted the fix_LowercaseStaticReferenceFixer branch January 24, 2024 19:32
@SpacePossum
Copy link
Contributor

Thanks @kubawerlos & @Wirone much appreciated 👍

danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
@kubawerlos @danog
fix: LowercaseStaticReferenceFixer - do not change typed constants (P…
56775d8 
…HP-CS-Fixer#7775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug - lowercase_static_reference break code
4 participants
@kubawerlos @coveralls @Wirone @SpacePossum