Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: function_to_constant get_class() replacement #7770

Merged
merged 6 commits into from Jan 30, 2024

Conversation

mvorisek
Copy link
Contributor

fix #2944

repro: https://3v4l.org/j0daX#v8.2.0

also modernize __CLASS__ usages to self::class as done by Rector

@mvorisek mvorisek marked this pull request as ready for review January 23, 2024 10:44
Copy link
Member

@julienfalque julienfalque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small coding style issue and ready to merge IMO

src/Fixer/LanguageConstruct/FunctionToConstantFixer.php Outdated Show resolved Hide resolved
@Wirone Wirone enabled auto-merge (squash) January 30, 2024 21:56
@Wirone Wirone merged commit 156192d into PHP-CS-Fixer:master Jan 30, 2024
25 checks passed
@mvorisek mvorisek deleted the fix_get_cl_repl branch January 30, 2024 22:15
@Wirone
Copy link
Member

Wirone commented Jan 30, 2024

Thank you @mvorisek 🍻

danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants