- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: ClassKeywordFixer
must run before FullyQualifiedStrictTypesFixer
#7767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
requested changes
Jan 22, 2024
ClassKeywordFixer
must run before FullyQualifiedStrictTypesFixer
Wirone
reviewed
Jan 23, 2024
tests/Fixtures/Integration/priority/class_keyword,fully_qualified_strict_types.test
Outdated
Show resolved
Hide resolved
Wirone
reviewed
Jan 23, 2024
tests/Fixtures/Integration/priority/class_keyword,fully_qualified_strict_types.test
Outdated
Show resolved
Hide resolved
Wirone
approved these changes
Jan 23, 2024
Thank you @krzysztofrewak 🍻! |
Thank you, @Wirone, for help! 🚀 |
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
…xer` (PHP-CS-Fixer#7767) Co-authored-by: Greg Korba <greg@codito.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic/fqcn
Fully Qualified Class Name usage and conversions
topic/priority
Problems related to fixers' priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without specified priority,
ClassKeywordFixer
works bad when combined withFullyQualifiedStrictTypesFixer
.For example this:
Would be transformed into:
and running CS check would fail, because we would need to run fixer again to receive expected: