Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docker - use gitlab reporter in GitLab integration example #7764

Merged
merged 4 commits into from Jan 30, 2024

Conversation

keradus
Copy link
Member

@keradus keradus commented Jan 20, 2024

No description provided.

@coveralls
Copy link

coveralls commented Jan 20, 2024

Coverage Status

coverage: 94.751%. remained the same
when pulling 05d6f9b on keradus:docs_docker2
into 62280c4 on PHP-CS-Fixer:master.

@@ -99,7 +99,7 @@ To integrate php-cs-fixer as check into Gitlab-CI, you can use a configuration l
php-cs-fixer:
image: ghcr.io/php-cs-fixer/php-cs-fixer:${FIXER_VERSION:-3-php8.3}
script:
php-cs-fixer check --diff --format=txt src
php-cs-fixer check --format gitlab src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be like this?

Suggested change
php-cs-fixer check --format gitlab src
php-cs-fixer check --format=gitlab src

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoudn't

why should or should not? both variants are valid.

@Wirone Wirone enabled auto-merge (squash) January 30, 2024 21:50
@Wirone Wirone merged commit 73b0905 into PHP-CS-Fixer:master Jan 30, 2024
25 checks passed
@keradus keradus deleted the docs_docker2 branch February 1, 2024 23:57
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants