fix: union PHPDoc support in fully_qualified_strict_types fixer
#7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
fully_qualified_strict_types fixerfully_qualified_strict_types fixer
mvorisek
force-pushed
the
fix_phpdoc_fqn_nullable_import
branch
from
b403669
to
81ffc39
Compare
mvorisek
force-pushed
the
fix_phpdoc_fqn_nullable_import
branch
from
81ffc39
to
c5e9d7e
Compare
mvorisek
force-pushed
the
fix_phpdoc_fqn_nullable_import
branch
from
e80ad64
to
94a2936
Compare
This was referenced Jan 13, 2024
|
Kindly ping @Wirone, the current master/release is broken. |
|
Wasn't the previous release broken too when it comes to this fix? I am just unable to review everything, I am aware of every PR, but simply don't have that much time. |
|
IDK, I had to cherrypick this fix into some repos and I would be happy if it can be merged and released asap. |
|
And it will be merged and released ASAP, with an emphasis on P 😉. You really need to remember we have work, families and hobbies, can't spend all the time on Fixer 😅. |
Wirone
added
topic/fqcn
mvorisek
force-pushed
the
fix_phpdoc_fqn_nullable_import
branch
3 times, most recently
from
9358b1f
to
b73b062
Compare
mvorisek
force-pushed
the
fix_phpdoc_fqn_nullable_import
branch
from
b73b062
to
6d2c124
Compare
Wirone
reviewed
Jan 17, 2024
Wirone
requested changes
Jan 18, 2024
nickvergessen
added a commit
to nextcloud/coding-standard
that referenced
this pull request
Feb 1, 2024
There are currently too many issues for the rule on the project itself #17 PHP-CS-Fixer/PHP-CS-Fixer#7719 Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
|
The feedback has been addressed, let's merge this PR. It is a bugfix and people already complains about the issue. |
Wirone
requested changes
Feb 5, 2024
Co-authored-by: Greg Korba <wirone@gmail.com>
Wirone
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\X\Y|nullPHPDoc was wrongly imported asuse X\Y|null;now it is fixed and full simple union support is added (related with #7619)
also fix shortening, previously the shortest name could be not-shortest (but was still correct)landed in #7752also fix shortening, in namespaced files, relative names are not further imported, match this behaviour for non-namespaced files if any matching use is present for name