Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phpdoc_align - fix multiline tag alignment issue #7630

Merged
merged 3 commits into from Dec 28, 2023

Conversation

keradus
Copy link
Member

@keradus keradus commented Dec 27, 2023

No description provided.

@GrahamCampbell
Copy link
Contributor

I don't think this is a bug. Missing the type is invalid syntax, so one should not expect CS to be applied.

@keradus
Copy link
Member Author

keradus commented Dec 27, 2023

It is a bug. Fixer should either not touch it at all (if we claim this to be invalid syntax), or touch it properly (without making 2nd line shifted by single space)

php-fig phpdoc never went out of draft,
phpdocumentator's phpdoc claims type is optional ref, same as regex we use in the Fixer

@keradus keradus marked this pull request as ready for review December 27, 2023 20:44
@keradus keradus enabled auto-merge (squash) December 27, 2023 20:48
@coveralls
Copy link

Coverage Status

coverage: 94.795%. remained the same
when pulling 96540b6 on keradus:xxx_bug
into 8c784d4 on PHP-CS-Fixer:master.

@keradus keradus changed the title fix: phpdoc_align - prove issue fix: phpdoc_align - fix multiline tag alignment issue Dec 27, 2023
@keradus keradus merged commit cb5d221 into PHP-CS-Fixer:master Dec 28, 2023
25 checks passed
@keradus keradus deleted the xxx_bug branch December 28, 2023 16:15
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants