chore: Preg - rework catching the error #7616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
force-pushed
the
preg_reworked
branch
from
be64a34
to
9051404
Compare
keradus
changed the title
This was referenced Dec 25, 2023
keradus
added a commit
to keradus/PHP-CS-Fixer
that referenced
this pull request
Dec 28, 2023
keradus
commented
Dec 28, 2023
| @@ -170,25 +170,27 @@ private static function removeUtf8Modifier($pattern) | |||
| private static function newPregException(int $error, string $errorMsg, string $method, array $patterns): PregException | |||
There was a problem hiding this comment.
I have the feeling that we could remove this method and use ExecutorWithoutErrorHandler directly in public methods, yet out of time on my side. Let's unblock PHPUnit v10 and hopefully we come back to refactor this Preg class afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #7606
PHPUnit migration is not as trivial as some could assume: 4dc05a0
changing the way of catching internal errors - as... well... you guessed it! PHPUnit is grabbing it with PHPUnit's internal handler!