CI: Fix editorconfig

[szepeviktor]

👀

[szepeviktor]

Character set was missing

[szepeviktor]

This was invalid and incomplete

[keradus]

Not all existing files following this rule. Mind to apply it first ?

[Wirone]

I was thinking about the same, but in the end I just thought that it will be applied anyway when files are modified. But maybe applying it all at once is better - for me not a strict requirement.

[szepeviktor]

🏃🏻‍♂️

[szepeviktor]

Done 🍏

[Wirone]

This file must be left as-is because it's auto-generated and it would lead to constant diffs (previous format would be restored after running the command) or would require to apply formatting in IDE before committing. We need to revert this change and ignore it somehow. I see that people suggest generated_code = true but I don't see this in official specs. Found the issue where ... = unset can be used for un-setting requirements. Or maybe we just can revert it and do not apply it again - nobody edits baseline manually anyway.

[szepeviktor]

Done.
If baseline is never opened in an EC-compatible IDE we should not care about it.

BTW I use EC for validation, not only as suggestions. https://github.com/greut/eclint

[szepeviktor]

Note

linguist-generated attribute (in .gitattributes) could be used to flag generated files.

[szepeviktor]

                git ls-files --cached \
                    | git check-attr --stdin --all \
                    | sed -n -e 's#^\(.\+\): linguist-generated: set$#":!:\1"#p' \
                    | xargs -- git grep --null --files-with-matches -I -e '.' -- \
                    | xargs --null -n 1 -- any command ...

[Wirone]

Thank you @szepeviktor 🍻

[keradus]

some files are still misconfigured.
eg prlint.json using 2 spaces, composer.json using 4

[szepeviktor]

some files are still misconfigured.
eg prlint.json using 2 spaces, composer.json using 4

I see!
It is hard to spot 4 space indentation when having 2 as the desired value.
2×2=4

[keradus]

It's even worse!
2+2=4, also!