-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NoSpacesAfterFunctionNameFixer
- do not remove space if the opening parenthesis part of an expression
#7430
fix: NoSpacesAfterFunctionNameFixer
- do not remove space if the opening parenthesis part of an expression
#7430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged as-is, comment is non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that yields' keys would make test cases more descriptive and easier to grasp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes, sometimes you want to have a different example of the same issue and there is dilemma of putting it in one code chunk or to split into a few smaller code samples.
NoSpacesAfterFunctionNameFixer
- do not remove space if the opening parenthesis part of an expression
Fixes #5950