Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: general restructure #7407

Merged
merged 33 commits into from Nov 4, 2023
Merged

CI: general restructure #7407

merged 33 commits into from Nov 4, 2023

Conversation

keradus
Copy link
Member

@keradus keradus commented Nov 2, 2023

No description provided.

@coveralls
Copy link

coveralls commented Nov 2, 2023

Coverage Status

coverage: 94.604% (+0.03%) from 94.578%
when pulling 5b3b02c on keradus:ci
into 77103ef on PHP-CS-Fixer:master.

@keradus keradus changed the title CI: misc CI: extract phar-build checks Nov 2, 2023
@keradus keradus marked this pull request as ready for review November 2, 2023 14:42
@keradus keradus marked this pull request as draft November 2, 2023 16:57
@keradus keradus changed the title CI: extract phar-build checks CI: general restructure Nov 3, 2023
@keradus keradus marked this pull request as ready for review November 3, 2023 17:46
shell: bash
run: echo "dir=$(composer config cache-dir)" >> $GITHUB_OUTPUT

- name: Cache dependencies
Copy link
Member Author

@keradus keradus Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so...

we are getting this error (only on the PR, i do not see it on master branch)
https://github.com/keradus/PHP-CS-Fixer/actions/runs/6748717442/job/18347647031#step:31:3

I think the cache is not stored (or maybe we need to have this config in master already?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/sca.yml Outdated Show resolved Hide resolved
.github/workflows/sca.yml Outdated Show resolved Hide resolved
@keradus
Copy link
Member Author

keradus commented Nov 3, 2023

I think we can review the whole PR already,
but I need to find root cause of that cache issue #7407 (comment)

@keradus keradus merged commit 74f6ba0 into PHP-CS-Fixer:master Nov 4, 2023
20 checks passed
@keradus keradus deleted the ci branch November 4, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants