CI: Run Symfony 6 compat check on PHP 8.1 #7383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
ci/symfony-6
branch
from
074e7b3
to
2dd830a
Compare
derrabus
changed the title
|
It was already refactored in #7366 but is waiting for the review. Since Symfony 6 bumped required version to 8.1 and we don't want to test 6.0 and 6.1+ separately, I just removed that constraint there. Please take a look and tell what you think about that approach 🙂. |
The |
keradus
approved these changes
Oct 22, 2023
|
we want to test explcitly with ^5 and with ^6 |
Wirone
added a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Oct 23, 2023
Wirone
added a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Oct 26, 2023
Wirone
added a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Nov 2, 2023
Wirone
added a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Nov 2, 2023
Wirone
added a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 6 has dropped support for PHP 8.0, see https://symfony.com/blog/symfony-6-1-will-require-php-8-1
PHP CS Fixer's CI has a job that pins all Symfony dependencies to version 6. This job runs with outdated and unmaintained Symfony 6.0.x packages which I believe was not intended. I propose to run that job on PHP 8.1 instead.