Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Improve QA process #7366

Merged
merged 7 commits into from
Nov 2, 2023
Merged

DX: Improve QA process #7366

merged 7 commits into from
Nov 2, 2023

Commits on Nov 2, 2023

  1. CI: Run tests and Fixer with higher granularity 

    It does not make sense to run tests and Fixer on each matrix' combination. We should explicitly run these only when really needed, without repeating same steps on same runtime.
    @Wirone
    Wirone committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e2b1235 View commit details
    Browse the repository at this point in the history

  2. Explicit requirements for Symfony ^5 / ^6 

    Reference: PHP-CS-Fixer#7383 (comment)
    @Wirone
    Wirone committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    76310a0 View commit details
    Browse the repository at this point in the history

  3. Improve conditions for job matrix

    @Wirone
    Wirone committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    de11bd0 View commit details
    Browse the repository at this point in the history

  4. CI: run both tests and Fixer after applying migration rules

    @Wirone
    Wirone committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8e6af60 View commit details
    Browse the repository at this point in the history

  5. CI: clean up jobs for PHP 7.4 

    Both tests and Fixer are run twice:
- on Symfony ^5 components with `--prefer-lowest` flag for Composer deps
- on highest deps available for this PHP version

Native type checks are run along with regular Fixer checks because they take only few seconds and there's no need to extract it to separate job - this wouldn't be optimisation.
    @Wirone
    Wirone committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f2c2186 View commit details
    Browse the repository at this point in the history

  6. Fix tests' execution on PHP 7.4

    @Wirone
    Wirone committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8ea7900 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @keradus
    keradus committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ed126b7 View commit details
    Browse the repository at this point in the history