New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: illegal offset type on file-wide return in ReturnToYieldFromFixer
#7318
fix: illegal offset type on file-wide return in ReturnToYieldFromFixer
#7318
Conversation
Thanks @juliangut for the contribution, but according to the contributing guide you should provide first commit with test case that reproduces the issue, and after CI failure provide the fix 🙂. Minimal requirement is a test case along with a fix, without test case we can't merge it. |
@Wirone hope the PR now follows contribution guidelines |
could you add this test?: (it will pass btw) yield [
'<?php
function foo(): iterable { return $z; }
return [1,2] ?> X <?php { echo 2; }'
]; I think your PR/fix is solid 👍 |
❤️😆 Looks good, please add @SpacePossum's test case, rebase the branch and it'll be ready for merge 👍. |
New test added. I've merged instead of rebased, hope it's not a problem, I assume PR will be squashed into a single commit anyway |
ReturnToYieldFromFixer
Thanks @juliangut and welcome to Fixer's contributors group 🍻! |
thanks @juliangut , nice fix :) |
Hopefully fixes #7317