feat: Add support for callable template in PHPDoc parser #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
callable_generic_support
branch
2 times, most recently
from
4a8b276
to
c2b0ec8
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
callable_generic_support
branch
from
c2b0ec8
to
e72c6dd
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
callable_generic_support
branch
2 times, most recently
from
c4bb5ce
to
531943b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
status/to verify
mvorisek
force-pushed
the
callable_generic_support
branch
from
531943b
to
f0b303d
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
callable_generic_support
branch
2 times, most recently
from
0f2c97d
to
e5d481e
Compare
mvorisek
force-pushed
the
callable_generic_support
branch
from
e5d481e
to
6e1f783
Compare
|
@Wirone may I ask you for a review? |
Wirone
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Test cases are clear and code look OK in general, but the actual logic for parsing callable template is too mysterious IMHO. Please provide context (as a comments), so it's easier to grasp. Please don't answer that code is self-describing, because it's not (for me) 😛 .
Wirone
approved these changes
Mar 13, 2024
Wirone
removed
the
status/to verify
Wirone
changed the title
|
Thank you @mvorisek 🍻! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for parsing callable PHPDoc type with template like
Closure<T of DateTimeInterface>(T): boolrelated phpstan phpstan/phpdoc-parser#232, phpstan/phpstan-src#2938 PRs