Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: config file - provide better link to Finder docs #6992

Merged
merged 9 commits into from Oct 29, 2023
Merged

docs: config file - provide better link to Finder docs #6992

merged 9 commits into from Oct 29, 2023

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented May 25, 2023

ref #6991

mvorisek
mvorisek reviewed May 25, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
@Wirone Wirone changed the title Improve of config file example with codebase docs: Improve of config file example with codebase May 25, 2023
Wirone
Wirone reviewed May 25, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
Wirone
Wirone requested changes May 25, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
doc/config.rst Outdated
->notPath('src/Symfony/Component/Translation/Tests/fixtures/resources.php')
->in(__DIR__)
->in(__DIR__) // 'src'
->exclude(['somedir', 'foo.php'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
->exclude(['somedir', 'foo.php'])
->exclude('somedir')

As you can see below:

NOTE: exclude will work only for directories, so if you need to exclude file, try notPath.

@94noni
Copy link
Contributor Author

94noni commented May 27, 2023

I will be afk for some days
Feel free to continue this PR as you desire to match your doc standards :)

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the status/to recover PRs that were closed without being merged, but can be refreshed and continued label Oct 19, 2023
@github-actions github-actions bot closed this Oct 19, 2023
@Wirone Wirone reopened this Oct 19, 2023
@Wirone Wirone added topic/documentation and removed status/stale status/to recover PRs that were closed without being merged, but can be refreshed and continued labels Oct 19, 2023
@coveralls
Copy link

Coverage Status

coverage: 94.603%. remained the same when pulling 9ade761 on 94noni:patch-1 into 813b1d3 on PHP-CS-Fixer:master.

keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
keradus
keradus reviewed Oct 29, 2023
View reviewed changes
doc/config.rst Outdated Show resolved Hide resolved
@keradus keradus changed the title docs: Improve of config file example with codebase docs: config.rst - provide better link to Finder docs Oct 29, 2023
@keradus keradus changed the title docs: config.rst - provide better link to Finder docs docs: config file - provide better link to Finder docs Oct 29, 2023
@keradus keradus mentioned this pull request Oct 29, 2023
Merged
@keradus
Copy link
Member

keradus commented Oct 29, 2023

thanks for your effort on this PR!

I decided to keep only the link, and redo the other part of docs #7396

@keradus keradus merged commit 723d106 into PHP-CS-Fixer:master Oct 29, 2023
14 checks passed
@94noni 94noni deleted the patch-1 branch February 11, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone requested changes

@mvorisek mvorisek mvorisek left review comments

@keradus keradus keradus left review comments

Assignees
No one assigned
Labels
topic/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@94noni @coveralls @keradus @Wirone @mvorisek