New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Use $tokens->getNamespaceDeclarations() to improve performance #6942

Merged

Wirone merged 1 commit into PHP-CS-Fixer:master from staabm:ns

May 6, 2023

Contributor

staabm commented May 6, 2023 •

edited

use the new method in even more places to utilize its caching.

in my local testing its just 1% faster though.
So in the end it would be more about consistency, not performance - at least in my workload.


          Use $tokens->getNamespaceDeclarations() to improve performance

bf572a7

staabm marked this pull request as ready for review

May 6, 2023 16:40

Wirone approved these changes

View reviewed changes

Wirone merged commit c1470f1 into PHP-CS-Fixer:master

14 checks passed

Member

Wirone commented May 6, 2023

Thank you @staabm 🍻

staabm deleted the ns branch

May 6, 2023 16:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment