Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add operator_linebreak rule to @Symfony #6877

Merged

Conversation

yguedidi
Copy link
Contributor

@yguedidi yguedidi commented Apr 2, 2023

After a discussion with @stof, this rule should be part of the @Symfony PHP-CS-Fixer ruleset.
Symfony code base is (almost, see symfony/symfony#49897) following it already

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4586394813

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.004%

Totals Coverage Status
Change from base Build 4584756507: 0.0%
Covered Lines: 22734
Relevant Lines: 24444

💛 - Coveralls

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Apr 3, 2023
This PR was merged into the 6.3 branch.

Discussion
----------

Apply operator_linebreak PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6877 for the PR on PHP-CS-Fixer

Commits
-------

6edc748 Apply operator_linebreak PHP-CS-Fixer rule
@yguedidi
Copy link
Contributor Author

yguedidi commented Apr 3, 2023

@keradus PR merged on Symfony side

@keradus keradus merged commit e937ae9 into PHP-CS-Fixer:master Apr 3, 2023
12 checks passed
@yguedidi yguedidi deleted the add-operator_linebreak-to-symfony branch April 3, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants