DX: PHPStan improvements #6868
Merged
DX: PHPStan improvements #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4600881262
💛 - Coveralls |
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
keradus
reviewed
Apr 1, 2023
julienfalque
reviewed
Apr 3, 2023
Wirone
force-pushed
the
codito/phpstan-improvement
branch
from
e77719c
to
085407c
Compare
|
@keradus sorry for the force push - I wanted to rebase branch to be up-to-date with master and then push only what was provided before + new commits in separate push (so Github could display compare view only for new commits), but I forgot and pushed everything at once 😩. I hope you used "Viewed" checkboxes and Github handle it properly for files that were not changed within rebase (Gitlab can do it, so I have such habit). |
Wirone
force-pushed
the
codito/phpstan-improvement
branch
2 times, most recently
from
9f1de92
to
744fda5
Compare
Wirone
force-pushed
the
codito/phpstan-improvement
branch
from
744fda5
to
7de2ba5
Compare
kubawerlos
reviewed
Apr 20, 2023
Wirone
force-pushed
the
codito/phpstan-improvement
branch
2 times, most recently
from
716ff79
to
480ff3b
Compare
Wirone
force-pushed
the
codito/phpstan-improvement
branch
3 times, most recently
from
911b9c8
to
35f6b49
Compare
kubawerlos
requested changes
May 6, 2023
Make `phpstan.neon` ignored by Git and allow people override default config (helpful especially for `editorUrl` and `parallel`). https://phpstan.org/config-reference#config-file
This will allow us to keep track of `ignoreErrors` and do not let outdated ignore rules be kept there.
Introduce PHPStan type aliases to re-use array shape within single file.
With explicit baseline file we know exactly where errors are it's easier to fix them. Also, with previous approach it was possible to fix N issue and introduce N other issues at the same time and PHPStan wouldn't complain. Now, it will report unmatched (fixed) errors and newly introduced ones.
Let's do not pretend there's some kind of more sophisticated type, use array shape in all places. In the future it should be replaced with some kind of DTO.
Reuse path stored in variable instead concatenating the same values again. Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
Wirone
force-pushed
the
codito/phpstan-improvement
branch
from
35f6b49
to
17f5f70
Compare
kubawerlos
approved these changes
May 6, 2023
|
Thank you @Wirone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in commits' messages, but let's summarise:
phpstan.neon(default config moved tophpstan.dist.neon)Plan for the future (in separate PRs):