New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: phpDoc to property/return/param Fixer - allow fixing mixed on PHP >= 8 #6356
feat: phpDoc to property/return/param Fixer - allow fixing mixed on PHP >= 8 #6356
Conversation
9d3b094
to
1768779
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of those fixers are outdated, they say:
- they only fix "non-mixed types"
- they require an old PHP version
Can you update them please?
@MortalFlesh , would you mind to address julienfalque's comments, so we can merge this great PR? |
Hello @keradus I will try to do it today, I'm kinda busy these days :) |
1768779
to
13af374
Compare
ebab931
to
67c1ff1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@MortalFlesh is it possible to rebase this PR, so we can check current pipeline result and continue the review process? |
This comment was marked as outdated.
This comment was marked as outdated.
67c1ff1
to
00e29bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to clean this up a little 😉.
00e29bb
to
4305639
Compare
Thank you @MortalFlesh 🍻 |
Hello,
I'm trying to use
PhpdocTo Property/Return/Param Fixers
for fixing amixed
type from phpdocs on PHP >= 8.0 - which allowsmixed
as a declared scalar type.It seems to me, it should work. But it is actually skipped before even trying to check if the type is allowed for the version.
I removed the
mixed
from a skipped types and it is checked against a version specific types later, so it works fine.I also unified test cases for all 3 fixers, so it lowers a brain damage for managing the tests.
PS:
I created the PR from
master
and marked it as a feature not as a bugfix, since I feel it as an improvement in the fixing - not fixing a bug, but I can change it if it should be a bugfix.