chore: Properly determine self-approval trigger commit #7936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
force-pushed
the
codito/fix-self-approval-commit-message-matcher
branch
2 times, most recently
from
8b2bafe
to
4316368
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
"To run a job based on the pull request's head branch name (as opposed to the pull request's base branch name), use the `github.head_ref` context in a conditional." https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request_target-workflow-based-on-the-head-or-base-branch-of-a-pull-request
Wirone
force-pushed
the
codito/fix-self-approval-commit-message-matcher
branch
from
4316368
to
1658329
Compare
keradus
approved these changes
Apr 14, 2024
|
@keradus unfortunately it does not work 😕. It seems like it tries to checkout branch from the fork, but it's not present in the cloned repo. I need to experiment with it in my fork, for now we need to revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see here commit message for self-approval is determined improperly when PR is created. Workflow takes last commit from
master, and it does not trigger the Bot.Source