Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NoSpacesAfterFunctionNameFixer - do not remove space if the opening parenthesis part of an expression #7430

Merged
merged 4 commits into from Nov 28, 2023
Merged

fix: NoSpacesAfterFunctionNameFixer - do not remove space if the opening parenthesis part of an expression #7430

merged 4 commits into from Nov 28, 2023

Conversation

kubawerlos
Copy link
Contributor

Fixes #5950

@kubawerlos kubawerlos marked this pull request as ready for review November 10, 2023 18:13
@coveralls
Copy link

coveralls commented Nov 10, 2023 •
edited

Coverage Status

coverage: 94.918%. remained the same
when pulling 882547e on 6b7562617765726c6f73:fix_NoSpacesAfterFunctionNameFixer
into cee6945 on PHP-CS-Fixer:master.

@kubawerlos kubawerlos closed this Nov 27, 2023
@kubawerlos kubawerlos reopened this Nov 27, 2023
Wirone
Wirone approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged as-is, comment is non-blocking.

tests/Fixer/FunctionNotation/NoSpacesAfterFunctionNameFixerTest.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that yields' keys would make test cases more descriptive and easier to grasp.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes, sometimes you want to have a different example of the same issue and there is dilemma of putting it in one code chunk or to split into a few smaller code samples.

@Wirone Wirone changed the title fix: NoSpacesAfterFunctionNameFixer - do not remove space if the opening parenthesis part of an expression fix: NoSpacesAfterFunctionNameFixer - do not remove space if the opening parenthesis part of an expression Nov 27, 2023
@kubawerlos kubawerlos merged commit 34d914c into PHP-CS-Fixer:master Nov 28, 2023
25 checks passed
@kubawerlos kubawerlos deleted the fix_NoSpacesAfterFunctionNameFixer branch November 28, 2023 16:59
@Wirone Wirone mentioned this pull request Dec 7, 2023
Closed
@keradus keradus mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

@mvorisek mvorisek Awaiting requested review from mvorisek

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoSpacesAfterFunctionNameFixer removes whitespace between echo and IIFE's parenthesis
4 participants
@kubawerlos @coveralls @Wirone @mvorisek