fix: illegal offset type on file-wide return in ReturnToYieldFromFixer

[juliangut]

Hopefully fixes #7317

[Wirone]

Thanks @juliangut for the contribution, but according to the contributing guide you should provide first commit with test case that reproduces the issue, and after CI failure provide the fix 🙂. Minimal requirement is a test case along with a fix, without test case we can't merge it.

[coveralls]

coverage: 94.652% (+0.004%) from 94.648% when pulling 64ada60 on juliangut:fix/returntoyieldfrom-offset-type into aafd2d6 on PHP-CS-Fixer:master.

[juliangut]

@Wirone hope the PR now follows contribution guidelines

[SpacePossum]

could you add this test?: (it will pass btw)

        yield [
            '<?php
function foo(): iterable { return $z; }

return [1,2] ?>  X  <?php { echo 2; }'
        ];

I think your PR/fix is solid 👍

[Wirone]

use yoda style you must

❤️😆

Looks good, please add @SpacePossum's test case, rebase the branch and it'll be ready for merge 👍.

[juliangut]

New test added. I've merged instead of rebased, hope it's not a problem, I assume PR will be squashed into a single commit anyway

[Wirone]

Thanks @juliangut and welcome to Fixer's contributors group 🍻!

[SpacePossum]

thanks @juliangut , nice fix :)