feature: [PHP8.2] Support for readonly classes #6745
Conversation
Wirone
changed the title
|
is it easily possible to split the commit into what Space' provided and new changes separately? now, you kind of ask for review everything from scratch :( |
|
@keradus this is only patch applied from @SpacePossum's commit taken from here, no new changes. I wanted to check if it passes on newest |
Pull Request Test Coverage Report for Build 4283243810
💛 - Coveralls |
|
FYI: Sorry for lack of response, I did not have time lately, but I'll try to look at it later today 🙂 |
These are changes initially proposed by SpacePossum in PHP-CS-Fixer#6624 but abandoned due to personal reasons. Since it's accepted by the author to use these changes, I've just applied the full patch, so we can continue work.
Wirone
force-pushed
the
codito/6604-support-for-readonly-classes
branch
2 times, most recently
from
1e99e74
to
a59ea7b
Compare
I wanted to commit suggestion from Github, but it would fail in tests (expected output had to be changed too).
Wirone
force-pushed
the
codito/6604-support-for-readonly-classes
branch
from
352ad95
to
12daa46
Compare
|
big thanks @SpacePossum and @Wirone , as well as @kubawerlos for nice review! |
|
nice one @Wirone 👍 🎉 |
|
To be fair, it's all thanks to @SpacePossum - I only did maintenance work to refresh the branch and fixed little issues to align the code with current CS rules. Anyway, happy that |
Fixes #6604.
These are changes initially proposed by SpacePossum in #6624 but abandoned due to personal reasons. Since it's accepted by the author to use these changes, I've just applied the full patch, so we can continue work.