[PHP8.2] Support for readonly classes

[Wirone]

The goal of this task is to provide support for readonly classes. New class-level keyword must not break any fixers and should be supported only for PHP 8.2+

[kubawerlos]

Would be nice to have indeed, can you propose a PR for it, please?

[SpacePossum]

We should update the tokenizer to make a custom CT::CLASS_READONLY token for this and than make PR's to update the rules that need it.

Maybe new rules:

• if a class has only readonly properties, make the class itself readonly, remove the readonly keyword from the properties
• if a class is readonly, remove the readonly keyword from the properties

[SpacePossum]

Just to double check, but anonymous classes cannot be readonly right? (not sure why TBH, didn't find anything on the subject)

[jaikdean]

Just to double check, but anonymous classes cannot be readonly right? (not sure why TBH, didn't find anything on the subject)

Correct, anonymous classes cannot be readonly.

[BenMorel]

2 points:

• indeed, anonymous classes cannot be readonly: https://3v4l.org/s536m
• interestingly, a readonly class can have redundant readonly properties: https://3v4l.org/4KTVg

-> It would be nice to provide a fixer to remove readonly from properties of readonly classes.

[alfredbez]

Looks like these two examples are valid:

readonly final class Foo {}

final readonly class Foo {}

But when I try to apply the final_class rule on that code it breaks:

Files that were not fixed due to errors reported during linting after fixing:
   1) /home/runner/work/php-cs-fixer-8.2/php-cs-fixer-8.2/Foo.php

Here's a small repo to reproduce the problem:

• failed CI output
• problematic file
• config

I did not test this against the PR from @mateuszsip

[SpacePossum]

it is all here #6624 , if anyone is interested in finishing it

[Wirone]

@alfredbez could you verify #6745 against your reproducer and check if it works properly?

[alfredbez]

This bug is solved with the change from the PR: CI output 🎉

(commit)

---

I also tried to change in #6744 but it does not work for the same reason.