Skip to content

Commit

Permalink
Merge branch 'master' into PSR12
Browse files Browse the repository at this point in the history
  • Loading branch information
keradus committed Oct 25, 2023
2 parents abddff1 + e008ba6 commit f5614f6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ jobs:

- operating-system: 'ubuntu-20.04'
php-version: '8.0'
job-description: 'with Symfony ^6'
execute-flex-with-symfony-version: '^6' # explicit check for Symfony 6.x compatibility

- operating-system: 'ubuntu-20.04'
php-version: '8.1'
job-description: 'with Symfony ^6'
execute-flex-with-symfony-version: '^6' # explicit check for Symfony 6.x compatibility

- operating-system: 'ubuntu-20.04'
php-version: '8.2'
Expand Down
4 changes: 2 additions & 2 deletions doc/rules/language_construct/nullable_type_declaration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ Example #1
--- Original
+++ New
<?php
-function bar(null|int $value, null|\Closure $callable): void {}
+function bar(?int $value, ?\Closure $callable): void {}
-function bar(null|int $value, null|\Closure $callable): int|null {}
+function bar(?int $value, ?\Closure $callable): ?int {}
Example #2
~~~~~~~~~~
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function getDefinition(): FixerDefinitionInterface
'Nullable single type declaration should be standardised using configured syntax.',
[
new VersionSpecificCodeSample(
"<?php\nfunction bar(null|int \$value, null|\\Closure \$callable): void {}\n",
"<?php\nfunction bar(null|int \$value, null|\\Closure \$callable): int|null {}\n",
new VersionSpecification(8_00_00)
),
new VersionSpecificCodeSample(
Expand Down
2 changes: 1 addition & 1 deletion tests/AutoReview/FixerFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ public function testFixerWithNoneDefaultPriorityIsTested(): void
}
}

self::assertEmpty($missing, 'Fixers without default priority and without priority tests: "'.implode('", "', array_keys($missing)).'."');
self::assertEmpty($missing, 'Fixers with non-default priority and yet without priority unit tests [vide "getFixersPriorityGraph()" and "getPhpDocFixersPriorityGraph()"]: "'.implode('", "', array_keys($missing)).'."');
}

/**
Expand Down

0 comments on commit f5614f6

Please sign in to comment.