DX: check deprecations exactly - order or count of expectation vs act…

…ual usage can vary, but result sets must be identical
PHP-CS-Fixer · Jan 15, 2024 · e84d2c2 · e84d2c2
1 parent 36fcb86
commit e84d2c2
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -35,10 +35,16 @@ abstract class TestCase extends BaseTestCase
     protected function tearDown(): void
     {
         if (null !== $this->previouslyDefinedErrorHandler) {
+            $this->actualDeprecations = array_unique($this->actualDeprecations);
+            sort($this->actualDeprecations);
+            $this->expectedDeprecations = array_unique($this->expectedDeprecations);
+            sort($this->expectedDeprecations);
             self::assertSame($this->expectedDeprecations, $this->actualDeprecations);
 
             restore_error_handler();
         }
+
+        parent::tearDown();
     }
 
     final public function testNotDefiningConstructor(): void
@@ -66,8 +72,6 @@ function (
                 ) {
                     if (E_USER_DEPRECATED === $code || E_DEPRECATED === $code) {
                         $this->actualDeprecations[] = $message;
-                        $this->actualDeprecations = array_unique($this->actualDeprecations);
-                        sort($this->actualDeprecations);
                     }
 
                     return true;