Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release-v5.0 branch #4930

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Merge release-v5.0 branch #4930

merged 1 commit into from
Feb 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: ac49aaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw closed this Feb 29, 2024
@Amxx Amxx reopened this Feb 29, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great.
Should we also include the 4.9.6 entry in the changelog. I think yes

@ernestognw
Copy link
Member

The only thing missing is the 4.9.6 entry but we didn't include them for 4.9.5. I think we can merge this and close #4931 unless you think the CHANGELOG entry is important.

@ernestognw
Copy link
Member

That is great. Should we also include the 4.9.6 entry in the changelog. I think yes

That was a quick answer. Ok, let's do it, but let's also add 4.9.5 entry, what do you think?

@Amxx
Copy link
Collaborator

Amxx commented Feb 29, 2024

I would add the 4.9.5 and 4.9.6 for completeness. Can be done in another PR

@ernestognw
Copy link
Member

I would add the 4.9.5 and 4.9.6 for completeness. Can be done in another PR

Ok, let's merge this one and I'll continue in the other PR

@ernestognw ernestognw merged commit 5705e82 into master Feb 29, 2024
22 of 23 checks passed
@ernestognw ernestognw deleted the merge/release-v5.0 branch February 29, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants