Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove utils/Counters.sol #4289

Merged
merged 5 commits into from
May 31, 2023
Merged

Remove utils/Counters.sol #4289

merged 5 commits into from
May 31, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented May 29, 2023 •
edited by frangio

Fixes #4233
Fixes LIB-890

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2023 •
edited

⚠️ No Changeset found

Latest commit: 9436034

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the base branch from master to next-v5.0 May 29, 2023 19:25
@frangio frangio mentioned this pull request May 30, 2023
Closed
@frangio frangio changed the base branch from next-v5.0 to master May 30, 2023 20:49
frangio
frangio approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frangio frangio enabled auto-merge (squash) May 31, 2023 03:11
@Amxx
Copy link
Collaborator Author

Amxx commented May 31, 2023

Do we want to add natspec comments so the upgradeability layout test passes?

@frangio
Copy link
Contributor

frangio commented May 31, 2023

No, we don't need those.

@frangio frangio disabled auto-merge May 31, 2023 14:40
@frangio frangio merged commit 2ee1da1 into OpenZeppelin:master May 31, 2023
13 of 14 checks passed
@Amxx Amxx deleted the remove/counters branch May 31, 2023 15:02
@H3liaw
Copy link

H3liaw commented Nov 6, 2023

why did you remove the CountersUpgradeable ?

@Amxx
Copy link
Collaborator Author

Amxx commented Nov 6, 2023

@H3liaw It was all discussed in the linked issue #4233

This was referenced May 26, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Counters.sol
3 participants
@Amxx @frangio @H3liaw