Fix TransparentUpgradeableProxy's transparency #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b082da8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
frangio
reviewed
Apr 3, 2023
…Amxx/openzeppelin-contracts into fix/TransparentUpgradeableProxy/ifAdmin
…arentUpgradeableProxy
frangio
reviewed
Apr 4, 2023
ernestognw
previously approved these changes
Apr 4, 2023
Co-authored-by: Ernesto García <ernestognw@gmail.com> Co-authored-by: Francisco <fg@frang.io>
frangio
approved these changes
Apr 5, 2023
frangio
pushed a commit
that referenced
this pull request
Apr 5, 2023
Co-authored-by: Francisco <fg@frang.io> Co-authored-by: Ernesto García <ernestognw@gmail.com> (cherry picked from commit 5523c14)
| /** | ||
| * @dev ERC-1967: Proxy Storage Slots. This interface contains the events defined in the ERC. | ||
| * | ||
| * _Available since v4.9._ |
There was a problem hiding this comment.
This is not correct since it's released as part of v4.8.3. Will open a PR @Amxx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TransparentUpgradeableProxy uses the
ifAdminmodifier to achieve transparency. If a non-admin address calls the proxy the call should be frowarded transparently. This works well in most cases, but the forwarding of some functions can fail if there is a selector conflict and decoding issue.Lets consider the
upgradeTo(address)function. The associated function selector is0x16a27ecd.If the implementation ever includes another function signature that happens to:
Then calling this function would not be possible. Any call would match
upgradeTo(address)on the proxy, and before theifAdminproxy has any chance to redirect the call, the abi decoder would fail to retrieve the expected address.This could be used by malicious a developer to block access to functions that is correctly implemented.
PR Checklist
npx changeset add)