Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore reentrancy inexecuteBatch and update Slither config #3955

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Ignore reentrancy inexecuteBatch and update Slither config #3955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad57085
ignore reentrancy for executeBatch
0xalpharush Jan 13, 2023
34079a2
bump slither version and force compilation with hardhat
0xalpharush Jan 13, 2023
4f87a90
add explanation for slither-disable
frangio Jan 13, 2023
1dca729
use latest slither always
frangio Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,7 @@ jobs:
- uses: actions/checkout@v3
- name: Set up environment
uses: ./.github/actions/setup
- run: rm foundry.toml
- uses: crytic/slither-action@v0.2.0
with:
slither-version: 0.9.1

codespell:
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'
Expand Down
3 changes: 3 additions & 0 deletions contracts/governance/TimelockController.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ contract TimelockController is AccessControl, IERC721Receiver, IERC1155Receiver
*
* - the caller must have the 'executor' role.
*/
// This function can reenter, but it doesn't pose a risk because _afterCall checks that the proposal is pending,
// thus any modifications to the operation during reentrancy should be caught.
// slither-disable-next-line reentrancy-eth
function executeBatch(
address[] calldata targets,
uint256[] calldata values,
Expand Down
3 changes: 2 additions & 1 deletion slither.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"detectors_to_run": "reentrancy-eth,reentrancy-no-eth,reentrancy-unlimited-gas",
"filter_paths": "contracts/mocks"
"filter_paths": "contracts/mocks",
"compile_force_framework": "hardhat"
}