Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit asset decimals in ERC4626 #3639

Merged
merged 17 commits into from
Aug 26, 2022
Merged

Inherit asset decimals in ERC4626 #3639

merged 17 commits into from
Aug 26, 2022

Commits on Jul 15, 2022

  1. wip

    @Amxx
    Amxx committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    2f37cc7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. test decimal inheritance

    @Amxx
    Amxx committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    dd881a2 View commit details
    Browse the repository at this point in the history

  2. add changelog entry

    @Amxx
    Amxx committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    7a46d8f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/erc4626/decimals

    @Amxx
    Amxx committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    1b63fc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Update contracts/mocks/ERC4626Mock.sol 

    Co-authored-by: Francisco <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    dd47839 View commit details
    Browse the repository at this point in the history

  2. use internal virtual function for the initial conversion rate

    @Amxx
    Amxx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    3adb5e3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'amxx/fix/erc4626/decimals' into fix/erc… 

    …4626/decimals
    @Amxx
    Amxx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    ceac1c1 View commit details
    Browse the repository at this point in the history

  4. fix lint

    @Amxx
    Amxx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    cbb8d8e View commit details
    Browse the repository at this point in the history

  5. add missing interfaces to the docs

    @Amxx
    Amxx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    06fce19 View commit details
    Browse the repository at this point in the history

  6. add changelog entry

    @Amxx
    Amxx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    4d291ca View commit details
    Browse the repository at this point in the history

  7. address comments from PR

    @Amxx
    Amxx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a0a43b5 View commit details
    Browse the repository at this point in the history

  8. fix lint

    @Amxx
    Amxx committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1719e3f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Francisco <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    4ac03c9 View commit details
    Browse the repository at this point in the history

  2. remove IERC20 → IERC20Permit inheritance

    @Amxx
    Amxx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    6bd75f9 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md

    @frangio
    frangio committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    32ee611 View commit details
    Browse the repository at this point in the history

  4. fetch underlyin asset's decimal value in constructor

    @Amxx
    Amxx committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    e5307c6 View commit details
    Browse the repository at this point in the history

  5. rename variable

    @frangio
    frangio committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    be4d899 View commit details
    Browse the repository at this point in the history