Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicitly clear ERC721 approval on burn #3538

Merged
merged 2 commits into from
Jul 9, 2022
Merged

Implicitly clear ERC721 approval on burn #3538

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a4c814
Update ERC721.sol
EthanOK Jul 9, 2022
b7fd935
fix test and add changelog entry
Amxx Jul 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/token/ERC721/ERC721.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ contract ERC721 is Context, ERC165, IERC721, IERC721Metadata {
_beforeTokenTransfer(owner, address(0), tokenId);

// Clear approvals
_approve(address(0), tokenId);
delete _tokenApprovals[tokenId];

_balances[owner] -= 1;
delete _owners[tokenId];
Expand Down