Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicitly clear ERC721 approval on transfers #3481

Merged
merged 4 commits into from
Jul 4, 2022

Commits on Jun 16, 2022

  1. Implicitly clear approval

    As per the ERC721 standard, the transfer function shouldn't emit an Approve event, as clearing the approval is implicit in the Transfer event.
    
    Docs regarding Approve event:
    ```
        /// @dev This emits when the approved address for an NFT is changed or
        ///  reaffirmed. The zero address indicates there is no approved address.
        ///  When a Transfer event emits, this also indicates that the approved
        ///  address for that NFT (if any) is reset to none.
    ```
    [EIP-721](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md)
    AnAllergyToAnalogy committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    b4eb5c7 View commit details
    Browse the repository at this point in the history
  2. update tests

    Amxx committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    4c19fa9 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Configuration menu
    Copy the full SHA
    26190c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7090f7 View commit details
    Browse the repository at this point in the history