fix: rpc result serde and avoid rate limits #4325
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1070,13 +1070,27 @@ mod tests { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn get_earliest_block() { | |||
| async fn get_block_with_transaction_data() { | |||
There was a problem hiding this comment.
Should this be renamed to signal that you're testing caching?
| pub v: u64, | ||
| /// Y-parity for EIP-2930 and EIP-1559 transactions. In theory these transactions types |
There was a problem hiding this comment.
Did this cause a crash when deserializing?
|
I merged as I only had one tiny nitpick and it seemed prudent to get this merged. It's still worth having a look at this question, @agostbiro: #4325 (comment) |
This PR started out as a quickfix for
Block<Transaction>deserialization that was blocking @Wodann , but then some new issues popped up for which I also included fixes. Specifically, this PR contains:Block<Transaction>to be deserialized fromserde_json::ValueTypedReceipt<Log>to be deserialized fromserde_json::ValueyParityinBlock. Geth recently started to returnyParityalongside thevparameter for EIP-2930 and EIP-1559 transactions even though these should only contain theyParityparameter in theory. I discovered this when fetching blocks from Infura.