Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6.qtwebengine: mark as broken on darwin #312987

Merged
merged 1 commit into from
May 19, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented May 19, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels May 19, 2024
@wegank wegank merged commit 9c4f6ca into NixOS:master May 19, 2024
27 of 29 checks passed
@wegank wegank deleted the qt6-qtwebengine-broken branch May 19, 2024 22:14
@Strum355
Copy link
Contributor

Strum355 commented Jun 7, 2024

Not compatible with macOS 11

stdenv.hostPlatform.darwinMinVersion returns 11 on (I believe) pretty much all current darwin versions, even on my existing 14.4 macbook, resulting in this package not building on any mac that Im aware of. Is this intentional? Doesnt seem to match what the comment states about it being specific to macOS 11

cc @reckenrode on how these variables are defined/what they mean

@K900
Copy link
Contributor

K900 commented Jun 7, 2024

Yes, that is intentional. We currently only have 10.x and 11.0 SDKs. @reckenrode is working on updating us to newer versions, which should unblock Qt again.

@reckenrode
Copy link
Contributor

Not compatible with macOS 11

stdenv.hostPlatform.darwinMinVersion returns 11 on (I believe) pretty much all current darwin versions, even on my existing 14.4 macbook, resulting in this package not building on any mac that Im aware of. Is this intentional? Doesnt seem to match what the comment states about it being specific to macOS 11

cc @reckenrode on how these variables are defined/what they mean

hostPlatform.darwinMinVersion set the deployment target.

Did upstream drop support for macOS 11, or do they simply require a newer SDK (that is not yet available in nixpkgs)? It is possible to use or require a newer SDK and support older OS deployment using availability checks and other techniques.

The currently available SDKs in nixpkgs are 10.12 and 11.0. After the ld64 and Darwin cross stuff lands, I will be working on an SDK refactor that will make changing the SDK more robust and adding new ones easier. There is no ETA on that except for by 24.11.

@Strum355
Copy link
Contributor

Strum355 commented Jun 7, 2024

Im presuming the qtwebengine doc may be out of date then, it still states SDK 11 for 6.7.x 馃 https://github.com/qt/qtwebengine/blob/v6.7.1/src/core/doc/src/qtwebengine-platform-notes.qdoc#L90
and the website version of it https://doc.qt.io/qt-6/qtwebengine-platform-notes.html#macos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants