Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lunacy: fix "Unsupported file format" toast at startup #312928

Merged
merged 1 commit into from
May 31, 2024

Conversation

eliandoran
Copy link
Contributor

@eliandoran eliandoran commented May 19, 2024

Description of changes

Whenever the application is started, a toast notification is shown:

“Unsupported file format. Please open a .sketch or image file”

It does not matter if this is a first start (with the Welcome sketch which does load properly), or if there are no sketches to be loaded.

Apparently the issue is the fact that we are running the application from a symbolic link. Running it directly from lib/Lunacy does seem to do the trick. In this case we probably need a wrapper.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update meta.mainProgram accordingly

@eliandoran eliandoran marked this pull request as draft May 19, 2024 17:22
@eliandoran eliandoran marked this pull request as ready for review May 19, 2024 18:15
@eliandoran
Copy link
Contributor Author

@eclairevoyant, thanks for noticing, I changed the executable's name accidentally and that would have broken a few things.
It should be OK now.

@Aleksanaa Aleksanaa merged commit 417df30 into NixOS:master May 31, 2024
25 checks passed
@eliandoran eliandoran deleted the dev/lunacy-fix-toast branch May 31, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants