Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

unison-ucm: 0.5.19 -> 0.5.20 #312922

Merged
merged 1 commit into from
May 22, 2024
Merged

unison-ucm: 0.5.19 -> 0.5.20 #312922

merged 1 commit into from
May 22, 2024

Conversation

ereslibre
Copy link
Member

@ereslibre ereslibre commented May 19, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Contributor

@sellout sellout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that discussion related to this happened on ceedubs/unison-nix#92.

Some minor suggestions, but I think this is good regardless.

Thanks!

pkgs/development/compilers/unison/default.nix Show resolved Hide resolved
pkgs/development/compilers/unison/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/unison/default.nix Outdated Show resolved Hide resolved
@sellout
Copy link
Contributor

sellout commented May 21, 2024

Oh, you might also want to update the description to check off more of the boxes 鈥撀爀.g., since you鈥檝e now built on darwin.

Copy link
Contributor

@sellout sellout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again!

@ofborg ofborg bot requested a review from sellout May 21, 2024 14:59
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you!

@wegank wegank merged commit 89f2346 into NixOS:master May 22, 2024
27 checks passed
@ereslibre ereslibre deleted the bump-unison branch May 22, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants