-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.setuptools-dso: rename from setuptools_dso #297047
python312Packages.setuptools-dso: rename from setuptools_dso #297047
Conversation
Result of 6 packages failed to build:
16 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can replace nose2
with pytestCheckHook
, I guess.
@natsukium please explain your comment with |
pytest is backwards compatible with unittest You can use |
Sorry for the lack of explanation. For example, unittest does not support disabling some tests, but pytest does, and we can disable them with pytestCheckHook and disabledTests. |
fda73dc
to
2685c87
Compare
@natsukium like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Regarding darwin build, it also fails on master.
Description of changes
part of #245383
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.