Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.setuptools-dso: rename from setuptools_dso #297047

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Mar 20, 2024

Result of nixpkgs-review pr 297047 run on x86_64-linux 1

6 packages failed to build:
  • python312Packages.skytemple-dtef
  • python312Packages.skytemple-dtef.dist
  • python312Packages.skytemple-files
  • python312Packages.skytemple-files.dist
  • python312Packages.skytemple-ssb-debugger
  • python312Packages.skytemple-ssb-debugger.dist
16 packages built:
  • python311Packages.setuptools-dso
  • python311Packages.setuptools-dso.dist
  • python311Packages.skytemple-dtef
  • python311Packages.skytemple-dtef.dist
  • python311Packages.skytemple-files
  • python311Packages.skytemple-files.dist
  • python311Packages.skytemple-ssb-debugger
  • python311Packages.skytemple-ssb-debugger.dist
  • python311Packages.tilequant
  • python311Packages.tilequant.dist
  • python312Packages.setuptools-dso
  • python312Packages.setuptools-dso.dist
  • python312Packages.tilequant
  • python312Packages.tilequant.dist
  • skytemple
  • skytemple.dist

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can replace nose2 with pytestCheckHook, I guess.

@Stunkymonkey
Copy link
Contributor Author

@natsukium please explain your comment with nose2. I am confused.

@lucasew
Copy link
Contributor

lucasew commented Mar 22, 2024

We can replace nose2 with pytestCheckHook, I guess.

pytest is backwards compatible with unittest

You can use pytestCheckHook to run both

@natsukium
Copy link
Member

Sorry for the lack of explanation.
nose2 and pytest are both extensions to unittest, the standard python testing library, and as lucasew said, they are both compatible with unittest.
The upstream does not use the nose feature, so we do not need it and prefer to use pytestCheckHook for maintainability.

For example, unittest does not support disabling some tests, but pytest does, and we can disable them with pytestCheckHook and disabledTests.

@Stunkymonkey
Copy link
Contributor Author

@natsukium like this?

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Regarding darwin build, it also fails on master.

@natsukium natsukium merged commit a53e20b into NixOS:master Mar 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants