Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

relnotes: init at 0.1.2 #277438

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david-r-cox
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@david-r-cox
Copy link
Member Author

Result of nixpkgs-review pr 277438 run on aarch64-darwin 1

1 package built:
  • relnotes

pkg-config
];

buildInputs = [ ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [ ]
buildInputs =

Comment on lines +35 to +36
meta = with lib;
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib;
{
meta = with lib; {

@david-r-cox
Copy link
Member Author

x86_64-linux fails with sfackler/rust-openssl#1663

Comment on lines +27 to +31
buildInputs = [ ]
++ lib.optionals stdenv.isDarwin
[ darwin.apple_sdk.frameworks.Security ]
++ lib.optionals stdenv.isLinux
[ openssl.dev ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [ ]
++ lib.optionals stdenv.isDarwin
[ darwin.apple_sdk.frameworks.Security ]
++ lib.optionals stdenv.isLinux
[ openssl.dev ];
buildInputs =
lib.optionals stdenv.isDarwin [
darwin.apple_sdk.frameworks.Security
] ++ lib.optionals stdenv.isLinux [
(lib.getDev openssl)
];

Comment on lines +35 to +36
meta = with lib;
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib;
{
meta = with lib; {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants