Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-support/php: remove obsolete autoloader-suffix #261088

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Oct 14, 2023

Since composer/composer#11663, the composer output is stable and reproducible, therefore, that prefix is now obsolete.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Since composer/composer#11663, the composer output is stable and reproducible, therefore, that prefix is now obsolete.
@drupol drupol requested a review from etu as a code owner October 14, 2023 16:01
@drupol
Copy link
Contributor Author

drupol commented Oct 14, 2023

@GrahamcOfBorg build phpPackages.composer

@etu etu merged commit ccaba16 into master Oct 17, 2023
23 of 24 checks passed
@drupol drupol deleted the build-support/php/remove-autoloader-prefix branch October 17, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants