Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.composer: use fetchgit #258281

Merged
merged 1 commit into from
Oct 1, 2023
Merged

phpPackages.composer: use fetchgit #258281

merged 1 commit into from
Oct 1, 2023

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Sep 30, 2023 •
edited

Using fetchgit prevent the composer.lock from being stripped out when fetchFromGitHub is being used

https://nixpk.gs/pr-tracker.html?pr=258281

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@drupol drupol mentioned this pull request Sep 30, 2023
Closed
12 tasks
@NetaliDev
Copy link
Member

Result of nixpkgs-review pr 258281 run on x86_64-linux 1

2 packages failed to build:
  • php82Packages.php-parallel-lint
  • php83Packages.php-parallel-lint
23 packages built:
  • adminer
  • bookstack
  • pdepend
  • php81Packages.box
  • php81Packages.castor
  • php81Packages.composer
  • php81Packages.php-parallel-lint
  • php81Packages.psysh
  • php82Packages.box
  • php82Packages.castor
  • php82Packages.composer
  • php82Packages.psysh
  • php83Packages.box
  • php83Packages.castor
  • php83Packages.composer
  • php83Packages.psysh
  • phpactor
  • phpdocumentor
  • pixelfed
  • platformsh
  • robo
  • snipe-it
  • vimPlugins.phpactor

Two packages fail to build, but that does not look like a composer problem:

error: builder for '/nix/store/24837mgbrxkdqzx79m40pc8ya5fd1pp9-php-php-parallel-lint-1.3.2.drv' failed with exit code 1;
       last 10 log lines:
       >   Error Output:
       >   ================
       >   Failed loading /nix/store/kz8ahpqyvz7cyj52kz417g65bkz3rqjh-php-opcache-8.1.
       >   24/lib/php/extensions/opcache.so:  /nix/store/kz8ahpqyvz7cyj52kz417g65bkz3r
       >   qjh-php-opcache-8.1.24/lib/php/extensions/opcache.so: undefined symbol: zen
       >   d_build_delayed_early_binding_list
       >
       >
       > compile [--debug] [--no-parallel] [--no-restart] [--dev] [--no-config] [--with-docker] [--composer-bin COMPOSER-BIN] [--allow-composer-check-failure] [-c|--config CONFIG] [-d|--working-dir WORKING-DIR]
       >
       For full logs, run 'nix log /nix/store/24837mgbrxkdqzx79m40pc8ya5fd1pp9-php-php-parallel-lint-1.3.2.drv'.
error: builder for '/nix/store/66l7q0j6zvv8n4jky49nhzvbacczp80b-php-php-parallel-lint-1.3.2.drv' failed with exit code 1;
       last 10 log lines:
       >   Error Output:
       >   ================
       >   Failed loading /nix/store/kz8ahpqyvz7cyj52kz417g65bkz3rqjh-php-opcache-8.1.
       >   24/lib/php/extensions/opcache.so:  /nix/store/kz8ahpqyvz7cyj52kz417g65bkz3r
       >   qjh-php-opcache-8.1.24/lib/php/extensions/opcache.so: undefined symbol: zen
       >   d_build_delayed_early_binding_list
       >
       >
       > compile [--debug] [--no-parallel] [--no-restart] [--dev] [--no-config] [--with-docker] [--composer-bin COMPOSER-BIN] [--allow-composer-check-failure] [-c|--config CONFIG] [-d|--working-dir WORKING-DIR]
       >
       For full logs, run 'nix log /nix/store/66l7q0j6zvv8n4jky49nhzvbacczp80b-php-php-parallel-lint-1.3.2.drv'.
error: 2 dependencies of derivation '/nix/store/vm72zp3djc13zzynjh7bb955psnl4p2w-review-shell.drv' failed to build

@etu
Copy link
Contributor

etu commented Oct 1, 2023 via email

@drupol
Copy link
Contributor Author

drupol commented Oct 1, 2023

Done.

@drupol
phpPackages.composer: use fetchgit
1231c76 
Using `fetchgit` prevent the `composer.lock` from being stripped out when `fetchFromGitHub` is being used
@ofborg ofborg bot requested a review from Ma27 October 1, 2023 09:46
@drupol
Copy link
Contributor Author

drupol commented Oct 1, 2023

@GrahamcOfBorg build phpPackages.composer

@drupol
Copy link
Contributor Author

drupol commented Oct 1, 2023

Auto merging this myself to avoid people reporting this issue in the upcoming days.

@drupol drupol merged commit d7186d6 into master Oct 1, 2023
22 checks passed
@drupol drupol deleted the php/composer/use-fetchgit branch October 1, 2023 13:02
@drupol drupol mentioned this pull request Oct 2, 2023
Closed
@yayayayaka
Copy link
Member

It appears the composer.lock had been excluded in composer's .gitattributes. Maybe open a PR in composer to fix that?

@drupol
Copy link
Contributor Author

drupol commented Oct 4, 2023

@Seldaek hello !

Would you be ok with that ? If yes, I can provide the PR.

@Seldaek
Copy link

Seldaek commented Oct 5, 2023

Sure, I don't really mind either way

@drupol drupol mentioned this pull request Oct 5, 2023
Merged
2 tasks
@drupol
Copy link
Contributor Author

drupol commented Oct 5, 2023

Thanks! PR is up at composer/composer#11674

@drupol drupol mentioned this pull request Oct 6, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin globin is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@drupol @NetaliDev @etu @yayayayaka @Seldaek @Ma27