Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

black: 23.3.0 -> 23.9.1 #254530

Merged
merged 1 commit into from Sep 13, 2023
Merged

black: 23.3.0 -> 23.9.1 #254530

merged 1 commit into from Sep 13, 2023

Conversation

ehllie
Copy link
Contributor

@ehllie ehllie commented Sep 11, 2023

Description of changes

Updated black to version 23.9.1 which supports the PEP 695 syntax.

Things done

  • Disabled for python <3.8, as support for 3.7 runtime was dropped in black version 23.7.0

  • Moved typing-extensions to dependencies for python runtimes <3.11

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)

  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 23.11 Release Notes (or backporting 23.05 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module

  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from autophagy and sveitser September 11, 2023 10:26
@natsukium
Copy link
Member

Result of nixpkgs-review pr 254530 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python310Packages.unstructured-inference
  • python310Packages.unstructured-inference.dist
  • unstructured-api
59 packages failed to build:
  • baserow
  • baserow.dist
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • irrd
  • irrd.dist
  • lektor
  • lektor.dist
  • paperless-ngx
  • python310Packages.altair
  • python310Packages.altair.dist
  • python310Packages.anywidget
  • python310Packages.anywidget.dist
  • python310Packages.bentoml
  • python310Packages.bentoml.dist
  • python310Packages.gradio
  • python310Packages.gradio-client
  • python310Packages.gradio-client.dist
  • python310Packages.gradio.dist
  • python310Packages.openllm
  • python310Packages.openllm-client
  • python310Packages.openllm-client.dist
  • python310Packages.openllm-core
  • python310Packages.openllm-core.dist
  • python310Packages.openllm.dist
  • streamlit (python310Packages.streamlit)
  • streamlit.dist (python310Packages.streamlit.dist)
  • python310Packages.unstructured-api-tools
  • python310Packages.unstructured-api-tools.dist
  • python310Packages.vega
  • python310Packages.vega.dist
  • python310Packages.watchfiles
  • python310Packages.watchfiles.dist
  • python311Packages.altair
  • python311Packages.altair.dist
  • python311Packages.anywidget
  • python311Packages.anywidget.dist
  • python311Packages.bentoml
  • python311Packages.bentoml.dist
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio.dist
  • python311Packages.openllm
  • python311Packages.openllm-client
  • python311Packages.openllm-client.dist
  • python311Packages.openllm-core
  • python311Packages.openllm-core.dist
  • python311Packages.openllm.dist
  • python311Packages.streamlit
  • python311Packages.streamlit.dist
  • python311Packages.unstructured-api-tools
  • python311Packages.unstructured-api-tools.dist
  • python311Packages.vega
  • python311Packages.vega.dist
  • python311Packages.watchfiles
  • python311Packages.watchfiles.dist
  • strictdoc
  • strictdoc.dist
85 packages built:
  • ansible-lint
  • ansible-lint.dist
  • black (python310Packages.black)
  • black-macchiato (python310Packages.black-macchiato)
  • black-macchiato.dist (python310Packages.black-macchiato.dist)
  • black.dist (python310Packages.black.dist)
  • blacken-docs
  • blacken-docs.dist
  • cwltool
  • cwltool.dist
  • nbqa
  • nbqa.dist
  • python310Packages.betterproto
  • python310Packages.betterproto.dist
  • python310Packages.cwl-upgrader
  • python310Packages.cwl-upgrader.dist
  • python310Packages.cwl-utils
  • python310Packages.cwl-utils.dist
  • python310Packages.detectron2
  • python310Packages.detectron2.dist
  • python310Packages.dirty-equals
  • python310Packages.dirty-equals.dist
  • python310Packages.flyingsquid
  • python310Packages.flyingsquid.dist
  • python310Packages.mypy-boto3-builder
  • python310Packages.mypy-boto3-builder.dist
  • python310Packages.pgmpy
  • python310Packages.pgmpy.dist
  • python310Packages.ptpython
  • python310Packages.ptpython.dist
  • python310Packages.pydantic-core
  • python310Packages.pydantic-core.dist
  • python310Packages.pytest-black
  • python310Packages.pytest-black.dist
  • python310Packages.pytest-examples
  • python310Packages.pytest-examples.dist
  • python310Packages.python-lsp-black
  • python310Packages.python-lsp-black.dist
  • python310Packages.schema-salad
  • python310Packages.schema-salad.dist
  • spyder (python310Packages.spyder)
  • spyder.dist (python310Packages.spyder.dist)
  • ufmt (python310Packages.ufmt)
  • ufmt.dist (python310Packages.ufmt.dist)
  • python311Packages.betterproto
  • python311Packages.betterproto.dist
  • python311Packages.black
  • python311Packages.black-macchiato
  • python311Packages.black-macchiato.dist
  • python311Packages.black.dist
  • python311Packages.cwl-upgrader
  • python311Packages.cwl-upgrader.dist
  • python311Packages.cwl-utils
  • python311Packages.cwl-utils.dist
  • python311Packages.detectron2
  • python311Packages.detectron2.dist
  • python311Packages.dirty-equals
  • python311Packages.dirty-equals.dist
  • python311Packages.flyingsquid
  • python311Packages.flyingsquid.dist
  • python311Packages.mypy-boto3-builder
  • python311Packages.mypy-boto3-builder.dist
  • python311Packages.pgmpy
  • python311Packages.pgmpy.dist
  • python311Packages.ptpython
  • python311Packages.ptpython.dist
  • python311Packages.pydantic-core
  • python311Packages.pydantic-core.dist
  • python311Packages.pytest-black
  • python311Packages.pytest-black.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-black
  • python311Packages.python-lsp-black.dist
  • python311Packages.schema-salad
  • python311Packages.schema-salad.dist
  • python311Packages.spyder
  • python311Packages.spyder.dist
  • python311Packages.ufmt
  • python311Packages.ufmt.dist
  • rstfmt
  • rstfmt.dist
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references

@natsukium
Copy link
Member

Result of nixpkgs-review pr 254530 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python310Packages.unstructured-inference
  • python310Packages.unstructured-inference.dist
  • unstructured-api
144 packages built:
  • ansible-lint
  • ansible-lint.dist
  • baserow
  • baserow.dist
  • black (python310Packages.black)
  • black-macchiato (python310Packages.black-macchiato)
  • black-macchiato.dist (python310Packages.black-macchiato.dist)
  • black.dist (python310Packages.black.dist)
  • blacken-docs
  • blacken-docs.dist
  • cwltool
  • cwltool.dist
  • dmarc-metrics-exporter
  • dmarc-metrics-exporter.dist
  • irrd
  • irrd.dist
  • lektor
  • lektor.dist
  • nbqa
  • nbqa.dist
  • paperless-ngx
  • python310Packages.altair
  • python310Packages.altair.dist
  • python310Packages.anywidget
  • python310Packages.anywidget.dist
  • python310Packages.bentoml
  • python310Packages.bentoml.dist
  • python310Packages.betterproto
  • python310Packages.betterproto.dist
  • python310Packages.cwl-upgrader
  • python310Packages.cwl-upgrader.dist
  • python310Packages.cwl-utils
  • python310Packages.cwl-utils.dist
  • python310Packages.detectron2
  • python310Packages.detectron2.dist
  • python310Packages.dirty-equals
  • python310Packages.dirty-equals.dist
  • python310Packages.flyingsquid
  • python310Packages.flyingsquid.dist
  • python310Packages.gradio
  • python310Packages.gradio-client
  • python310Packages.gradio-client.dist
  • python310Packages.gradio.dist
  • python310Packages.mypy-boto3-builder
  • python310Packages.mypy-boto3-builder.dist
  • python310Packages.openllm
  • python310Packages.openllm-client
  • python310Packages.openllm-client.dist
  • python310Packages.openllm-core
  • python310Packages.openllm-core.dist
  • python310Packages.openllm.dist
  • python310Packages.pgmpy
  • python310Packages.pgmpy.dist
  • python310Packages.ptpython
  • python310Packages.ptpython.dist
  • python310Packages.pydantic-core
  • python310Packages.pydantic-core.dist
  • python310Packages.pytest-black
  • python310Packages.pytest-black.dist
  • python310Packages.pytest-examples
  • python310Packages.pytest-examples.dist
  • python310Packages.python-lsp-black
  • python310Packages.python-lsp-black.dist
  • python310Packages.schema-salad
  • python310Packages.schema-salad.dist
  • spyder (python310Packages.spyder)
  • spyder.dist (python310Packages.spyder.dist)
  • streamlit (python310Packages.streamlit)
  • streamlit.dist (python310Packages.streamlit.dist)
  • ufmt (python310Packages.ufmt)
  • ufmt.dist (python310Packages.ufmt.dist)
  • python310Packages.unstructured-api-tools
  • python310Packages.unstructured-api-tools.dist
  • python310Packages.vega
  • python310Packages.vega.dist
  • python310Packages.watchfiles
  • python310Packages.watchfiles.dist
  • python311Packages.altair
  • python311Packages.altair.dist
  • python311Packages.anywidget
  • python311Packages.anywidget.dist
  • python311Packages.bentoml
  • python311Packages.bentoml.dist
  • python311Packages.betterproto
  • python311Packages.betterproto.dist
  • python311Packages.black
  • python311Packages.black-macchiato
  • python311Packages.black-macchiato.dist
  • python311Packages.black.dist
  • python311Packages.cwl-upgrader
  • python311Packages.cwl-upgrader.dist
  • python311Packages.cwl-utils
  • python311Packages.cwl-utils.dist
  • python311Packages.detectron2
  • python311Packages.detectron2.dist
  • python311Packages.dirty-equals
  • python311Packages.dirty-equals.dist
  • python311Packages.flyingsquid
  • python311Packages.flyingsquid.dist
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio.dist
  • python311Packages.mypy-boto3-builder
  • python311Packages.mypy-boto3-builder.dist
  • python311Packages.openllm
  • python311Packages.openllm-client
  • python311Packages.openllm-client.dist
  • python311Packages.openllm-core
  • python311Packages.openllm-core.dist
  • python311Packages.openllm.dist
  • python311Packages.pgmpy
  • python311Packages.pgmpy.dist
  • python311Packages.ptpython
  • python311Packages.ptpython.dist
  • python311Packages.pydantic-core
  • python311Packages.pydantic-core.dist
  • python311Packages.pytest-black
  • python311Packages.pytest-black.dist
  • python311Packages.pytest-examples
  • python311Packages.pytest-examples.dist
  • python311Packages.python-lsp-black
  • python311Packages.python-lsp-black.dist
  • python311Packages.schema-salad
  • python311Packages.schema-salad.dist
  • python311Packages.spyder
  • python311Packages.spyder.dist
  • python311Packages.streamlit
  • python311Packages.streamlit.dist
  • python311Packages.ufmt
  • python311Packages.ufmt.dist
  • python311Packages.unstructured-api-tools
  • python311Packages.unstructured-api-tools.dist
  • python311Packages.vega
  • python311Packages.vega.dist
  • python311Packages.watchfiles
  • python311Packages.watchfiles.dist
  • rstfmt
  • rstfmt.dist
  • strictdoc
  • strictdoc.dist
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references

natsukium
natsukium approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think my machine was bad.

@natsukium natsukium merged commit e060e58 into NixOS:master Sep 13, 2023
24 checks passed
@ehllie ehllie deleted the black branch September 13, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@autophagy autophagy Awaiting requested review from autophagy

@sveitser sveitser Awaiting requested review from sveitser

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehllie @natsukium