zxing-cpp updates #252861
Merged
zxing-cpp updates #252861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Singer <felixsinger@posteo.net> Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
- Use rec-less, overlay-style overridable recursive attributes (in effect since NixOS#119942) - Add passthru.updateScript - Remove nested with under meta.
- Inherit basically everything from zxing-cpp - Remove patches
|
If you have time, could you please rename the python module from |
|
Way better! Edit: failed because infinite loop of doom. I will do it in another PR. |
AndersonTorres
force-pushed
the
zxing-cpp
branch
from
44fe958
to
7208739
Compare
lukegb
approved these changes
Sep 2, 2023
AndersonTorres
force-pushed
the
zxing-cpp
branch
from
7208739
to
55ca056
Compare
|
I think this is what broke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #220579
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)