-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pillow & python3Packages.pillow-simd: Fix cross compilation #249136
Conversation
Fixes the build time error: `ModuleNotFoundError: No module named 'setuptools'`.
The hook should make setuptools available, even when cross-compiling. |
From what I can see it only gets added if using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed pkgsCross.*.python3Packages.pillow
for me.
This causes over 13k rebuilds in total. Why merge directly to master? |
Don't the docs say that small changes go to master? Or did I miss something? I just saw that the CONTRIBUTING.md file got recently expanded from the time I created this PR, maybe I just missed something new there, I'll go re-read it. Sorry! EDIT: Yes, I just saw the new flow of merged pull requests section about branches. Again, SORRY! |
The automatic red |
Reapplied in 094bfcf |
…oss compilation"" This reverts commit 68eb957, reversing changes made to 347a238. Moving the big rebuild to staging; original PR NixOS#249136, revert NixOS#251367
Fixes the build time error:
ModuleNotFoundError: No module named 'setuptools'
.Description of changes
Added
setuptools
onnativeBuildInputs
, so that it's available at build time when cross compiling.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)