-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3.pkgs.async-generator: rename from async_generator #248081
Conversation
I don't think it has to as we're using super and not self. |
@ofborg build python310Packages.async-generator |
Result of 5 packages built:
|
@ofborg build python310Packages.async-generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
How come this caused rebuilds? |
I'm not sure, probably because I changed the source to use SRI hash. |
No, the only actual rebuild is nixops_unstable. That's related to poetry2nix. |
Description of changes
For #245383.
@adisbladis: Does this part in poetry2nix/default.nix need to change?
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)