Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.cx-freeze: switch to pyproject and rename #246900

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 3, 2023

Description of changes

  1. Switch to pyproject.toml, which upstream already uses. Extracted from Switch to PyPA build, installer, and flit-core to build Python packages #245509 when I was testing something. Unfortunately, I don't remember what now, but we should still do this.
  2. Normalize its attribute name, part of Normalize python-modules attribute names and pnames #245383.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mausch
Copy link
Member

mausch commented Aug 3, 2023

LGTM 👍
Too bad #243787 hasn't been merged yet, which makes it more difficult to test this.

@tjni
Copy link
Contributor Author

tjni commented Aug 3, 2023

Thanks for the review! Hope yours gets committed soon too.

@FRidh FRidh merged commit 65a8bb4 into NixOS:master Aug 7, 2023
25 checks passed
@tjni tjni deleted the cx-freeze branch August 7, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants