Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.backports_*: remove #245894

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

natsukium
Copy link
Member

Description of changes

remove the following python310Packages

  • backports_csv
  • backports_functools_lru_cache
  • backports_tempfile
  • backports_unittest-mock
  • backports_weakref

relates to #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

we no longer need to backport to python2
we no longer need to backport to python3.2
we no longer need to backport to python3.3
we no longer need to backport to python3.2
we no longer need to backport to python3.3
@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 245894 run on x86_64-linux 1

8 packages built:
  • python310Packages.ritassist
  • python310Packages.ritassist.dist
  • python310Packages.sseclient
  • python310Packages.sseclient.dist
  • python311Packages.ritassist
  • python311Packages.ritassist.dist
  • python311Packages.sseclient
  • python311Packages.sseclient.dist

@mweinelt mweinelt merged commit e8d56b9 into NixOS:master Jul 28, 2023
20 checks passed
@natsukium natsukium deleted the backports/remove branch July 28, 2023 23:36
@bryango
Copy link
Member

bryango commented Aug 3, 2023

This PR breaks all python2 build. See e.g. #246631.

@zimbatm
Copy link
Member

zimbatm commented Aug 3, 2023

I think it's a sign that python2 should be removed from nixpkgs

@mweinelt
Copy link
Member

mweinelt commented Aug 3, 2023

Given that we don't build it in review, it feels like it's game over.

@bryango
Copy link
Member

bryango commented Aug 3, 2023

Maybe for now we should mark python2 as broken? Also, there is a new PR #246976 to re-introduce the missing dep for python2.

My build of python2 is only for the gimp plugin ecosystem, which still heavily relies on it. I am okay with dropping python2 support, but then I will have to switch to flatpak or appimage for gimp 😱

@natsukium
Copy link
Member Author

I will try not to break as much as I can notice, but I don't have the time to maintain python2.
I think you need to pin the revision of nixpkgs for gimp or make an effort to keep python2 with current users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants